-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 563: Correct references to 3.10 default adoption #2086
Conversation
pep-0563.rst
Outdated
This is projected to become the default behavior starting in Python 3.11 or | ||
later. Use of annotations incompatible with this PEP is no longer supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since @brettcannon approves I'm okay with this, but we really should wait for the discussion about PEP 649 before we announce any "projections". This may well never become the default behavior, if PEP 649 prevails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be appropriate to address the current situation in this PEP or are edits generally limited to corrections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can mark it with e.g. Update: or Note:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG except for 1 nit. Thanks!
pep-0563.rst
Outdated
``__future__`` import in Python 3.7. | ||
|
||
|
||
Rationale and Goals | ||
=================== | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this blank line back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. On it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
Edited two sentences to reflect that PEP 563 won't be default until at least 3.11 if ever.
Resolves #2084